I’m typing this on an iPhoneX I got on day of release. I’ve had a new battery and it’s still perfect. I kept telling myself I’d wait for USB-C, but now it’s here I’m just not bothered. I think the only reason I would have to upgrade is when mobile apps drop support for iOS 16. What “must have” feature are you using to justify an upgrade?
I probably wouldn’t upgrade. The X is still fine, and sounds like it’s still working for your usecase. Wait another generation and see if you feel like it offers something that you’ve gotta have vs your current phone.
The only reason I upgraded my 11 -> 14 Pro Max was the battery life and screen size.
It’s good to get out of the “must upgrade” mentality, especially when you’re asking others to give you a reason to.